Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh fixes #3378

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Gh fixes #3378

merged 2 commits into from
Oct 10, 2023

Conversation

mstoykov
Copy link
Contributor

What?

Fix problems with the changes from #3371

Why?

So that release can work

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added the ci label Oct 10, 2023
@mstoykov mstoykov added this to the v0.48.0 milestone Oct 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5ceb210) 72.81% compared to head (e746a96) 72.96%.

❗ Current head e746a96 differs from pull request most recent head b06cf45. Consider uploading reports for the commit b06cf45 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3378      +/-   ##
==========================================
+ Coverage   72.81%   72.96%   +0.15%     
==========================================
  Files         259      261       +2     
  Lines       20016    20018       +2     
==========================================
+ Hits        14574    14607      +33     
+ Misses       4507     4484      -23     
+ Partials      935      927       -8
Flag Coverage Δ
ubuntu 72.90% <ø> (?)
windows 72.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit 6e2c8e8 into master Oct 10, 2023
22 checks passed
@mstoykov mstoykov deleted the ghFixes branch October 10, 2023 14:14
@olegbespalov olegbespalov modified the milestones: v0.48.0, v0.47.0 Nov 17, 2023
@Porkepix Porkepix mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiade oleiade oleiade approved these changes

@codebien codebien codebien approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
v0.48.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mstoykov @codecov-commenter @oleiade @codebien @olegbespalov